Use either authlib-injector or system properties, not both #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves fn2006#154 In 1.20+, authlib-injector wants to intercept https://api.minecraftservices.com/publickeys [0], but if we override the services server using -Dminecraft.api.services.host, the request does not get intercepted. That's not an issue for API servers that implement the /publickeys route, but Ely.by does not. A decent solution is to not set these -Dminecraft.api.*.host system properties when authlib-injector is available, since authlib-injector expects authlib to make requests to Mojang's API servers. [0] yushijinhun/authlib-injector@18a0ce2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #154
In 1.20+, authlib-injector wants to intercept
https://api.minecraftservices.com/publickeys [0], but if we override the services server using
-Dminecraft.api.services.host, the request does not get intercepted.That's not an issue for API servers that implement the
/publickeysroute, but Ely.by does not. A decent solution is to not set these-Dminecraft.api.*.hostsystem properties when authlib-injector is available, since authlib-injector expects authlib to make requests to Mojang's API servers.[0] yushijinhun/authlib-injector@18a0ce2